Fix to honor image's original colormap #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I did have some inverting logic in the bin2c.py, the way I figured it should be in the program though is if the bit is set ( & 1 << bit) -> draw black, which is what I'm doing there. So in this case I'd probably leave it as-is. |
|
Makes sense, and I did see that after I submitted this PR. Sorry to have wasted your time; should've looked first. I'll submit a PR with adding an optional parameter to the converters to give the user the option to output an inverted or normal image.c to the bin2c and png2c converters. Should've done that in the first place. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've inverted the logical conditional around whether the A button is pressed, because whites are being converted to black. I don't know if that was a conscious decision (haven't reviewed bin2c.py closely}, but inverting this conditional lookup will retain whites and black as the original image intended.